Skip to content

fix(v2): update Masterminds/semver import to v3 for Go 1.25 compatibility#5217

Draft
leaanthony wants to merge 1 commit into
masterfrom
fix/5063-semver-import
Draft

fix(v2): update Masterminds/semver import to v3 for Go 1.25 compatibility#5217
leaanthony wants to merge 1 commit into
masterfrom
fix/5063-semver-import

Conversation

@leaanthony

@leaanthony leaanthony commented Apr 23, 2026

Copy link
Copy Markdown
Member

Summary

  • Updates github.com/Masterminds/semver import to github.com/Masterminds/semver/v3 across all v2 code
  • Updates go.mod dependency from v1.5.0 to v3.3.1
  • Fixes installation failure on Go 1.25+ where the v1 module path no longer resolves

Test plan

  • Existing internal/gomod and internal/github tests pass with the updated import
  • go mod tidy completes successfully
  • Installation via go install github.com/wailsapp/wails/v2/cmd/wails@latest will now work with Go 1.25+

Fixes #5063

fix: update Masterminds/semver import to v3 for Go 1.25 compatibility
2641c7d 
The github.com/Masterminds/semver v1.5.0 module no longer resolves
correctly with Go 1.25, causing installation failures. Update all
imports to github.com/Masterminds/semver/v3 v3.3.1.

Fixes #5063
@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ffdb8c5-c0f6-4cac-87d9-57da61be8219

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/5063-semver-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leaanthony

leaanthony commented May 2, 2026

Copy link
Copy Markdown
Member Author

🤖 PR Triage Review

✅ Accepted

Updates Masterminds/semver import to v3 for Go 1.25 compatibility (v2). Dependency migration.

Platform: All (v2)

Next Steps: Dispatching for testing on all platforms.

Reviewed by Wails PR Reviewer Bot

@leaanthony leaanthony added this to the v2.13.0 milestone May 20, 2026
@taliesin-ai taliesin-ai mentioned this pull request Jun 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

reviewed ✅ v2-only

Projects

None yet

Milestone

v2.13.0

Development

Successfully merging this pull request may close these issues.

install wails@latest. find the version of Masterminds/semver error

1 participant

@leaanthony